extensions: Simplify openPrefs()

The module is now only used inside the gnome-shell process, so
we don't have to handle the case where it is used from prefs,
and we can use regular imports for shell modules.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2837>

diff --git a/js/extensions/extension.js b/js/extensions/extension.js
index 125b7a35059eee65e2a62bef13d12935f29e36c0..b9e72584a95f0e865f331e992050a9c7ba3560bd 100644 (file)
--- a/js/extensions/extension.js
+++ b/js/extensions/extension.js
@@ -8,6 +8,8 @@ export {
     pgettext
 } from './sharedInternals.js';
 
+const {extensionManager} = imports.ui.main;
+
 /**
  * Open the preference dialog of the current extension
  */
@@ -17,12 +19,5 @@ export function openPrefs() {
     if (!extension)
         throw new Error('openPrefs() can only be called from extensions');
 
-    try {
-        const extensionManager = imports.ui.main.extensionManager;
-        extensionManager.openExtensionPrefs(extension.uuid, '', {});
-    } catch (e) {
-        if (e.name === 'ImportError')
-            throw new Error('openPrefs() cannot be called from preferences');
-        logError(e, 'Failed to open extension preferences');
-    }
+    extensionManager.openExtensionPrefs(extension.uuid, '', {});
 }